Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in /storage/content/49/145849/famitracker.com/public_html/forum/classes/dbHandler.php on line 29 FamiTracker
Login:
Menu:
Post: Author:
FamiTracker > General > Bug Reports & Feature Requests > cannot Expand Pattern containing a D00 Owner: Stratelier New post
Page 1 of 1 Sort:  
cannot Expand Pattern containing a D00 Posted: 2014-09-23 21:19  (Last Edited: 2014-09-24 00:49) Reply | Quote
Stratelier



Member for: 2954 days
Status: Offline

#62119
[versions affected: at least 0.4.2 ~ 0.4.4]

This is actually similar to the [url=http://famitracker.com/forum/posts.php?id=6128]previous bug involving copy/paste operations around a D00, but this one's much easier to reproduce.

- Take any pattern that terminates early via D00 (see attached file, song 1).
- Select the pattern (e.g. Ctrl+A or Edit -> Select All), and Expand Pattern.

Results:
- Only the first half of the pattern data has been expanded; the latter half has been deleted. (Presumably because the latter half extends past where the D00 effect was initially issued - but the D00 should be expanded right along with everything else.)

Tangientially related bugs:
- If expanding a pattern that contains a D00 or Bxx effect, these effects should be shifted down +1 additional row after expansion (because they take effect [i]after[/i] their respective row is played; to keep them on the same row will throw their timing off).
- If you shrink a pattern that contains a D00 or Bxx effect on an [i]odd-numbered[/i] row, the effect gets deleted outright (with resulting negative effects on song playback). Any such D00/Bxx should be shifted up 1 row before shrinking.
- If expanding a pattern that terminates via a D00 or Bxx [i]from a different channel[/i] (see attached file, song 2), Famitracker should ignore the other channel's effect and continue to expand the selected pattern beyond the D00/Bxx row (because that pattern ID could be played elsewhere for its full length).

In any case, expanding a pattern should not stop at a D00 (or Bxx) command but proceed to the full frame length as specified in the song settings. (Additionally: If it extends past the full frame length, FamiTracker can warn that part of the pattern may be lost)

_______________________
Where to find me:
YouTube: [url=http://youtube.com/user/stratelier]http://youtube.com/user/stratelier
DeviantArt: [url=http://stratadrake.deviantart.com/]http://stratadrake.deviantart.com/
Attachments:
testing.ftm (2 Kb)
Posted: 2014-09-23 21:44 Reply | Quote
poodlecock

Avatar

Member for: 3398 days
Location: !wow
Status: Offline

#62122
I can confirm that this bug is present, and I have encountered it while tracking before.

_______________________
"im going to continue making this crazy stuff then after a while my style will be so sick that you will be like damn suuun that shit is so sick i dont even get it. i will be like bro its ok.. you dont have to." -omgdonut
Posted: 2014-09-23 22:44 Reply | Quote
jsr
Administrator

Avatar

Member for: 5925 days
Location: Sweden
Status: Offline

#62127
I'll check for a solution for this, but the workaround so far is to remove the D00 command if you need to use expand.

_______________________
Programmer and developer
Page 1 of 1 Sort: