FamiTracker

Post:

Author:

FamiTracker > General > Bug Reports & Feature Requests > Out of bounds TriggerNote with absolute arps Owner: rainwarrior

New post

Page 1 of 1

Sort:

Out of bounds TriggerNote with absolute arps Posted: 2012-08-08 23:37 (Last Edited: 2012-08-08 23:39)

Reply | Quote

rainwarrior

Avatar

Member for: 5622 days
Location: Canada
Status: Offline

#37992

ChannelHandler.cpp line 633 wrote:

m_Period = TriggerNote(m_iNote + Value);

This can generate notes above 95, causing an assert in TriggerNote (line 229) in debug. Not sure what consequences this has in release, but since it's an assert I presume it's not expected to happen. Should probably be clamped to 0-95?

(This is using the current source repository, 8/08/2012)

Posted: 2012-08-09 00:16

Reply | Quote

jsr
Administrator

Avatar

Member for: 7396 days
Location: Sweden
Status: Offline

#37993

Good find. It could potentially cause a crash since it's used as an index to a pointer, so I've checked in a fix.

_______________________
Programmer and developer

Page 1 of 1

Sort: