Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in /storage/content/49/145849/famitracker.com/public_html/forum/classes/dbHandler.php on line 29
FamiTracker
If I create an FTM in 0.3.7 with a speed over 20, it will not open in 0.3.8b.
I think the problem is:
[quote=FamiTrackerTypes.h]const int MIN_TEMPO = 20;
const int MAX_SPEED = 19;[/quote]
Should be:
[quote=FamiTrackerTypes.h]const int MIN_TEMPO = 0x20;
const int MAX_SPEED = 0x1F;[/quote]
Another related problem, should this:
[quote=SoundGen.cpp]if (EffParam > MIN_TEMPO)[/quote]
Be this?
[quote=SoundGen.cpp]if (EffParam >= MIN_TEMPO)[/quote]
Otherwise F20 will still set speed instead of tempo.
I've tried to get this sorted out now. MAX_SPEED was changed to 0x20 in the previous version as this was what the help file actually said and I thought a larger speed range would be more useful, but that seemed to cause only problems for people and was requested to be changed back.
The if-statment was actually also a bug and caused the split-point to be off by one between the song settings and speed/tempo command. I've changed that now.
I also removed an assert so files with any speed should load now.
I'm with rainwarrior, for all the reasons he's stated. I've got at least one piece that I've had to change to get it to sound right with the new split.
Ok I see.
I didn't think it was necessary first but I'm thinking about adding a compatibility mode so it's possible to switch the split-point if necessary, that should solve the problem with older files.
