FamiTracker

Post:

Author:

FamiTracker > General > Bug Reports & Feature Requests > Slow speed bug in 0.3.8 beta Owner: rainwarrior

New post

Page 1 of 1

Sort:

Slow speed bug in 0.3.8 beta Posted: 2012-07-13 04:19 (Last Edited: 2012-07-13 04:44)

Reply | Quote

rainwarrior

Avatar

Member for: 829 days
Location: Canada
Status: Offline

#36724

If I create an FTM in 0.3.7 with a speed over 20, it will not open in 0.3.8b.

I think the problem is:

FamiTrackerTypes.h wrote:

const int MIN_TEMPO = 20;
const int MAX_SPEED = 19;

Should be:

FamiTrackerTypes.h wrote:

const int MIN_TEMPO = 0x20;
const int MAX_SPEED = 0x1F;

Another related problem, should this:

SoundGen.cpp wrote:

if (EffParam > MIN_TEMPO)

Be this?

SoundGen.cpp wrote:

if (EffParam >= MIN_TEMPO)

Otherwise F20 will still set speed instead of tempo.

Attachments:

too_slow.ftm (0 Kb)

Posted: 2012-07-19 02:44

Reply | Quote

jsr
Administrator

Avatar

Member for: 2604 days
Location: Sweden
Status: Offline

#36914

I've tried to get this sorted out now. MAX_SPEED was changed to 0x20 in the previous version as this was what the help file actually said and I thought a larger speed range would be more useful, but that seemed to cause only problems for people and was requested to be changed back.

The if-statment was actually also a bug and caused the split-point to be off by one between the song settings and speed/tempo command. I've changed that now.

I also removed an assert so files with any speed should load now.

_______________________
Programmer and developer

Posted: 2012-07-19 06:03

Reply | Quote

rainwarrior

Avatar

Member for: 829 days
Location: Canada
Status: Offline

#36917

Hmm. Going back has caused problems a couple times too. Particularly there's been a few DemoCompo entries that work in 0.3.7 but fail in the beta. Sad

I personally liked 0x20/0x1F as the split best because it's easiest to see and understand in the tracker.

Anyhow, it's your call.

Posted: 2012-07-19 10:13

Reply | Quote

modusponens

Avatar

Member for: 1423 days
Location: Redmond, WA
Status: Offline

#36937

I'm with rainwarrior, for all the reasons he's stated. I've got at least one piece that I've had to change to get it to sound right with the new split.

Posted: 2012-07-23 02:14

Reply | Quote

jsr
Administrator

Avatar

Member for: 2604 days
Location: Sweden
Status: Offline

#37048

Ok I see.
I didn't think it was necessary first but I'm thinking about adding a compatibility mode so it's possible to switch the split-point if necessary, that should solve the problem with older files.

_______________________
Programmer and developer

Posted: 2012-07-23 03:04

Reply | Quote

modusponens

Avatar

Member for: 1423 days
Location: Redmond, WA
Status: Offline

#37055

An excellent idea!

Page 1 of 1

Sort: