Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in /storage/content/49/145849/famitracker.com/public_html/forum/classes/dbHandler.php on line 29 FamiTracker
Login:
Menu:
Post: Author:
FamiTracker > General > Bug Reports & Feature Requests > VRC6 tuning off by one Owner: rainwarrior New post
Page 1 of 1 Sort:  
VRC6 tuning off by one Posted: 2011-12-19 21:44 Reply | Quote
rainwarrior

Avatar

Member for: 4150 days
Location: Canada
Status: Offline

#27720
I noticed this a little while ago when making an NSF of the Scriabin Piano Sonata, but didn't look into it more until just now. After a careful inspection of the pitch tables and how they sound, I've noticed the playback frequency of the VRC6 saw is off by 1. In the attached example, E-6 at P80 should actually be the same pitch as the square E-6 (in the pitch table they share an effective greatest common denominator 14*16). However, in FamiTracker 0.3.7 we only hear this if I put a P7F on there to increase the frequency value by 1.

In VRC6.cpp, line 113:

Counter = Frequency;

Should be:

Counter = Frequency + 1;

The pitch tables are actually fine, and the exported NSF will match them as they should be. This is only a problem with FamiTracker's playback. (I can check in this change if you like, jsr.)

What this means is that, especially in the high register, VRC6 Saw will sound slightly more in tune with a P7F (in FamiTracker 0.3.7) but if played by an NSF player, you'd want to keep the regular pitch (P80).


Attachments:
vrc6_tuning_test.ftm (1 Kb)
Posted: 2011-12-20 17:21 Reply | Quote
psn

Avatar

Member for: 4321 days
Location: England
Status: Offline

#27740
Nice find. I've noticed this too and, as you said, it's definitely only a problem with Famitracker's playback (exported nsfs work fine). It'd be great if this could be fixed come the next update.

Posted: 2011-12-20 19:42 Reply | Quote
ElHuesudoII

Avatar

Member for: 4525 days
Status: Offline

#27742
Did you have to use an octave that high?

my ears oh god

Posted: 2011-12-20 21:02  (Last Edited: 2011-12-20 21:08) Reply | Quote
rainwarrior

Avatar

Member for: 4150 days
Location: Canada
Status: Offline

#27743
The example was for science, not for aesthetics.

You can transpose it down to E-2 if you like. That's the next lowest place where the scales actually line up on a GCD. (The effect is subtler though; being off by one in that octave is much more slight.)

Posted: 2012-01-06 01:30 Reply | Quote
jsr
Administrator

Avatar

Member for: 5924 days
Location: Sweden
Status: Offline

#28413
Thanks for finding this, I've checked in a fix already.

_______________________
Programmer and developer
Posted: 2012-02-29 08:22 Reply | Quote
Fezuke

Avatar

Member for: 4004 days
Location: Le Gardeur, Quebec
Status: Offline

#31130
Thank you so much for this fix. Most of my songs are VRC6 and I kept thinking I was spending too much time on Famitracker and that my ears were starting to fail me. I honestly freaked out a few times thinking something was seriously wrong with me. What a relief.

_______________________
[url=http://soundcloud.com/fezuke/sets]My 8-Bit Soundcloud
[url=http://soundcloud.com/fezuke-2/sets]My Other Project Soundcloud
Page 1 of 1 Sort: